Compatible issue with node@10.13 - node@10.17 #6548
Assignees
Comments
|
Jack, this is related to the agnostification work. Could you PTAL? |
|
Ah, this is unfortunate. Our CI does run on 10.X but it runs on 10.19 so we managed to circumvent this problem. I guess we can introduce a helper whilst we have to support <10.19 to ensure we get the import from the right place, #6549 looks like a good start, thanks! |
jackfranklin
added a commit
that referenced
this issue
Oct 26, 2020
We saw in #6548 that the `fs.promises` module was experimental in Node <10.17 and as such we introduced issues for users on 10.15. Until we can drop Node v10 (it's EOL is 30-04-20201 https://github.com/nodejs/Release#release-schedule) we should run our tests on an old Node 10 to avoid regressing in this area.
jackfranklin
added a commit
that referenced
this issue
Oct 26, 2020
* chore: run unit tests on node 10.15 We saw in #6548 that the `fs.promises` module was experimental in Node <10.17 and as such we introduced issues for users on 10.15. Until we can drop Node v10 (it's EOL is 30-04-20201 https://github.com/nodejs/Release#release-schedule) we should run our tests on an old Node 10 to avoid regressing in this area. * chore: helper for importing fs safely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Tell us about your environment:
5.4.010.15.0fs.promisesis experimental innode@10.13 ~ node@10.17, so the result ofObject.getOwnPropertyDescriptor(require('fs'), 'promises').enumerableisfalse, which means https://github.com/puppeteer/puppeteer/blob/main/src/common/helper.ts#L322 this line would throwCan not read property open from undefinedThe text was updated successfully, but these errors were encountered: