fix: ignore spurious bindingCalled events #6538
Conversation
src/common/DOMWorld.ts
Outdated
| payload = JSON.parse(event.payload); | ||
| } catch { | ||
| // The binding was either called by something in the page or it was | ||
| // called before our wrapper was initialized |
There was a problem hiding this comment.
just for my understanding: what might cause this? Just some code running before we set up our binding ?
There was a problem hiding this comment.
Exactly. I can't make out how it happens, but very rarely we'll call the ariaQueryHandler binding before the pageBinding wrapper is set up.
johanbay
force-pushed
the
fix-onBindingCalled-flake
branch
from
c21a3cc
to
95984a8
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
johanbay
force-pushed
the
fix-onBindingCalled-flake
branch
from
95984a8
to
c9341aa
Compare
No description provided.