chore(agnostification): agnostify web socket connections #6520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullewis
approved these changes
Oct 16, 2020
| const getWebSocketTransportClass = async () => { | ||
| return isNode | ||
| ? (await import('../node/NodeWebSocketTransport.js')).NodeWebSocketTransport | ||
| : (await import('./BrowserWebSocketTransport.js')) |
There was a problem hiding this comment.
Does there need to be a subdirectory for browser-centric code?
There was a problem hiding this comment.
Yeah, I think probably there does. But then it'll get a bit messy with node/browser/common where common will sometimes conditionally load in things. But maybe that's fine?
I might leave this for a follow up PR - let me know if you feel strongly to fix this now 👍
There was a problem hiding this comment.
I don't personally think it's a blocker if you're planning to do it anyway.
| @@ -22,7 +22,7 @@ import { assert } from '../common/assert.js'; | |||
| import { helper, debugError } from '../common/helper.js'; | |||
| import { LaunchOptions } from './LaunchOptions.js'; | |||
| import { Connection } from '../common/Connection.js'; | |||
| import { WebSocketTransport } from '../common/WebSocketTransport.js'; | |||
| import { NodeWebSocketTransport as WebSocketTransport } from '../node/NodeWebSocketTransport.js'; | |||
There was a problem hiding this comment.
Do you want to rename the import? Might be better to refactor it to use the new name.
There was a problem hiding this comment.
Yeah, I think so. Will rework in follow-up.
mathiasbynens
approved these changes
Oct 19, 2020
This PR updates the socket transport code to swap between a Node web socket transport or a web one based on the `isNode` environment. It also adds unit tests to the browser tests that show we can connect in a browser.
jackfranklin
force-pushed
the
browser-socket-transport
branch
from
b937bf4
to
66ac8e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the socket transport code to swap between a Node web socket transport or a web one based on
isNode. It also adds unit tests to the browser tests that show we can connect in a browser.