Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(queryhandler): add custom query handler docs #6476

Merged
merged 1 commit into from Oct 7, 2020
Merged

docs(queryhandler): add custom query handler docs #6476

merged 1 commit into from Oct 7, 2020

Conversation

johanbay
Copy link
Collaborator

@johanbay johanbay commented Oct 7, 2020

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 7, 2020
mathiasbynens
mathiasbynens approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When we ship custom query handlers (remove the experimental status) we can essentially copy this to the docs/api.md as well.

src/common/Puppeteer.ts Outdated Show resolved Hide resolved
@johanbay johanbay merged commit cc7f1fd into main Oct 7, 2020
@johanbay johanbay deleted the custom-query-docs branch October 7, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@jackfranklin jackfranklin Awaiting requested review from jackfranklin

@hanselfmu hanselfmu Awaiting requested review from hanselfmu

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanbay @mathiasbynens