Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure debug logging in browser #6210

Merged
merged 1 commit into from Jul 20, 2020

Conversation

jackfranklin
Copy link
Collaborator

The Node debug library uses the DEBUG environment variable to
configure what gets logged. Our browser version just logs everything;
this commit changes it to look for window.__PUPPETEER_DEBUG and matches the behaviour accordingly:

  • If the value is not set, nothing is logged.
  • If the value is set to * everything is logged.
  • If the value is set to a string foo, messages with that prefix are
    logged.
  • If the value is set to a string ending in *, e.g. foo*, messages
    with prefixes that start with foo are logged.

The Node debug library uses the `DEBUG` environment variable to
configure what gets logged. Our browser version just logs everything;
this commit changes it to look for `window.__PUPPETEER_DEBUG` and matches the behaviour accordingly:

* If the value is not set, nothing is logged.
* If the value is set to `*` everything is logged.
* If the value is set to a string `foo`, messages with that prefix are
  logged.
* If the value is set to a string ending in `*`, e.g. `foo*`, messages
  with prefixes that start with `foo` are logged.
@paullewis
Copy link
Contributor

Do you want any tests for this?

@jackfranklin
Copy link
Collaborator Author

@paullewis , yes but we can't yet until we have browser test frameworks set up. Which is on the agnostification list of work to be done.

@jackfranklin jackfranklin merged commit b2f6918 into main Jul 20, 2020
@jackfranklin jackfranklin deleted the configure-debug-logging-browser branch July 20, 2020 10:05
@christian-bromann
Copy link
Contributor

@jackfranklin would you mind giving feedback on #5786 I would love for Puppeteer to provide even more insights about what it is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants