Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The puppeteer failing the build due to audit issue. #5522

Closed
hadaabhi201 opened this issue Mar 18, 2020 · 11 comments
Closed

The puppeteer failing the build due to audit issue. #5522

hadaabhi201 opened this issue Mar 18, 2020 · 11 comments

Comments

@hadaabhi201
Copy link

hadaabhi201 commented Mar 18, 2020

Steps to reproduce

Tell us about your environment:

  • Puppeteer version:2.1.1
  • Platform / OS version: MacOS Mojave (10.14.6)
  • URLs (if applicable):
  • Node.js version: v12.12.0

What steps will reproduce the problem?

$ npm init -y
$ npm install puppeteer --save
$ npm audit

What is the expected result?
Pass the audit with 0 vulnerability

What happens instead?

Fails the build:

Moderate : Prototype Pollution
Package : minimist
Patched in : >=0.2.1 <1.0.0 || >=1.2.3
Dependency of : puppeteer
Path : puppeteer > extract-zip > mkdirp > minimist
More info : https://npmjs.com/advisories/1179

found 1 moderate severity vulnerability in 51 scanned packages
1 vulnerability requires manual review. See the full report for details.

@prios-ben-beckerman
Copy link

See max-mapper/extract-zip#85

@taewookim
Copy link

having same issue.. (and not a node guy)
what's the work around?

@taewookim
Copy link

tried downgrading to 2.1.1 and 2.1.0.. and even 2.0.0

All having same issues

@taewookim
Copy link

taewookim commented Mar 20, 2020

Related issue

@aslushnikov - ANy thoughts on this issue?

@cyclingzealot
Copy link

cyclingzealot commented Mar 20, 2020

I'm waiting on pull request max-mapper/extract-zip#85 to happen. But that repo has had no activity since May 2018. https://github.com/SakiiCode/extract-zip/ has that pull request done (https://github.com/SakiiCode/extract-zip/commit/921fa811f7b6dcda82736dce18a69b960051dc96).

In npm, is there any way to tell the npm package manager to use a different repo for a dependency of a dependency?

@taewookim
Copy link

taewookim commented Mar 20, 2020

Ditto @cyclingzealot

BTW that repo looks hostaged (one issue that GitHub should take notice but won't take any action). Seen this happen with with other repos. Maybe it's better to fork and install directly from your own repo?

@cyclingzealot
Copy link

cyclingzealot commented Mar 20, 2020

SakiiCode has heard you can change the source of a transitive dependency with https://www.npmjs.com/package/npm-force-resolutions , but he hasn't checked that out yet.

@taewookim
Copy link

taewookim commented Mar 20, 2020

@aslushnikov I noticed you're on the playwright project.

Random tangent questions about playright

  1. is it a "drop-in" replacement for puppeteer?
  2. are you spending more time on that? should we be transitioning over to that?

Regarding q2... looking at pup contributors vs playwright contribturos .. seems like the major contributors migrated over

@stale
Copy link

stale bot commented Jun 26, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jun 26, 2022
@cyclingzealot
Copy link

I prefer documenting resolution over letting staleness auto-close. I think this can be closed. I used npm-force-resolutions and then later on an upgrade to extract-zip was made.

@stale
Copy link

stale bot commented Jul 27, 2022

We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it!

@stale stale bot closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants