Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting): drops obsolete dependencies #5354

Merged
merged 1 commit into from Jul 14, 2020

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jan 28, 2020

It looks like chromium dropped gconf in 2017, while at it remove
some other libs from the gtk2 era and bump libappindicator to a gtk3
version.

Current dependencies list for chromium 79 used as reference:
https://chromium.googlesource.com/chromium/src.git/+/refs/tags/79.0.3945.144/build/install-build-deps.sh#232

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@xrmx
Copy link
Contributor Author

xrmx commented Jan 28, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jackfranklin
Copy link
Collaborator

@xrmx hey I'm sorry this never landed. If you fancy fixing up the conflict we can get this change in?

It looks like chromium dropped gconf in 2017, while at it remove
some other libs from the gtk2 era and bump libappindicator to a gtk3
version.

Current dependencies list for chromium 79 used as reference:
https://chromium.googlesource.com/chromium/src.git/+/refs/tags/79.0.3945.144/build/install-build-deps.sh#232
@xrmx
Copy link
Contributor Author

xrmx commented Jul 8, 2020

@jackfranklin sure, rebased on top of main

@mathiasbynens mathiasbynens merged commit fb80610 into puppeteer:main Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants