feat(firefox): implement missing launcher options #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements `puppeteer.defaultArgs()` and also missing options, such as `ignoreDefaultArgs`.
aslushnikov
changed the title
test/launcher.spec.js
Outdated
| @@ -248,20 +238,20 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p | |||
| }); | |||
| it_fails_ffox('should have default url when launching browser', async function() { | |||
| const browser = await puppeteer.launch(defaultBrowserOptions); | |||
| await new Promise(x => setTimeout(x, 1000)); | |||
| @@ -58,7 +58,7 @@ pref("browser.startup.homepage_override.mstone", "ignore"); | |||
| pref("toolkit.cosmeticAnimations.enabled", false); | |||
|
|
|||
| // Do not close the window when the last tab gets closed | |||
There was a problem hiding this comment.
this comment looks wrong now.
JoelEinbinder
approved these changes
Feb 20, 2019
kiku-jw
pushed a commit
to kiku-jw/puppeteer
that referenced
this pull request
Apr 6, 2019
This patch implements `puppeteer.defaultArgs()` and also missing options, such as `ignoreDefaultArgs`.
This was referenced Feb 3, 2020
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
puppeteer.defaultArgs()and also missingoptions, such as
ignoreDefaultArgs.Drive-by: simplify Chrome-Puppeteer startup sequence using
browser.waitForTargethelper.