Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firefox): support Browser.target() #4028

Merged
merged 2 commits into from Feb 17, 2019

Conversation

aslushnikov
Copy link
Contributor

Support browser target.

Drive-by: switch over to a more devtools'ish protocol:

  • use targetId instead of pageId everywhere
  • use target events instead of tab events

Support browser target.

Drive-by: switch over to a more devtools'ish protocol:

- use `targetId` instead of `pageId` everywhere
- use target events instead of tab events
@aslushnikov aslushnikov merged commit 4a4793a into puppeteer:master Feb 17, 2019
@aslushnikov aslushnikov deleted the browser-target branch February 17, 2019 18:23
kiku-jw pushed a commit to kiku-jw/puppeteer that referenced this pull request Apr 6, 2019
Support browser target.

Drive-by: switch over to a more devtools'ish protocol:

- use `targetId` instead of `pageId` everywhere
- use target events instead of tab events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant