Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: throw an error in case of page.evaluate returning non-Serializable value #2420

Closed
yanivefraim opened this issue Apr 19, 2018 · 1 comment
Closed

feature request: throw an error in case of page.evaluate returning non-Serializable value #2420

yanivefraim opened this issue Apr 19, 2018 · 1 comment

Comments

@yanivefraim
Copy link
Contributor

follow-up for #2418:

Today, page.evaluate returns undefined in case of a non-Serializable returned object (see docs). It could be nice to have an error for such case (it is not intuitive to have undefined returned here, IMO)
@yanivefraim yanivefraim changed the title throw an error in case of page.evaluate returning non-Serializable value feature request: throw an error in case of page.evaluate returning non-Serializable value Apr 19, 2018
@yanivefraim yanivefraim changed the title feature request: throw an error in case of page.evaluate returning non-Serializable value feature request: throw an error in case of page.evaluate returning non-Serializable value Apr 19, 2018
@yanivefraim yanivefraim mentioned this issue Apr 20, 2018
Closed
@aslushnikov
Copy link
Contributor

aslushnikov commented Apr 26, 2018 •
edited

Throwing an error would be a breaking change; let's consider it as a part of #2079 (I've updated the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aslushnikov @yanivefraim