From 611ed7080ee5929ed5440d768475498ed14b975d Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Wed, 23 Nov 2022 14:53:18 +0100 Subject: [PATCH 1/2] chore: update deprecation script (#9315) Removed deprecation for puppeteer-core as we normally don't deprecate it since it does not download the browser binaries. --- .github/workflows/publish.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c445ddccb9884..6f3bcddd25342 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -27,12 +27,14 @@ jobs: run: | npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN npm publish --workspace packages/${GITHUB_REF_NAME%-v*} - - name: Deprecate old versions + - name: Deprecate old Puppeteer versions if: ${{ startsWith(github.ref_name, 'puppeteer-v') }} + env: + NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN_PUPPETEER}} run: | + npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN version_range=$(node tools/get_deprecated_version_range.js) npm deprecate puppeteer@"$version_range" "$version_range is no longer supported" - npm deprecate puppeteer-core@"$version_range" "$version_range is no longer supported" docker-publish: name: Publish Docker image runs-on: ubuntu-latest From da92055e9c187f4d0cce6ca548bc69689c452b6d Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Wed, 23 Nov 2022 15:11:26 +0100 Subject: [PATCH 2/2] chore: include headless in the flaky test expectation (#9316) --- test/TestExpectations.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/TestExpectations.json b/test/TestExpectations.json index ecfb4d8a4956a..8aa467fdc4312 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -2120,7 +2120,7 @@ { "testIdPattern": "[waittask.spec] waittask specs Frame.waitForSelector should survive cross-process navigation", "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "headful"], + "parameters": ["firefox"], "expectations": ["PASS", "FAIL"] } ]