From 9aede4ea3eecb947b010b39efd33aa9761ef08a9 Mon Sep 17 00:00:00 2001 From: Randolf J Date: Thu, 1 Sep 2022 17:09:20 +0200 Subject: [PATCH] chore: fix tests --- src/common/Frame.ts | 10 +++++++++- test/src/page.spec.ts | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/common/Frame.ts b/src/common/Frame.ts index 515e1d91566d0..c93292052515f 100644 --- a/src/common/Frame.ts +++ b/src/common/Frame.ts @@ -872,8 +872,13 @@ export class Frame { element = document.createElement('style'); element.appendChild(document.createTextNode(content!)); } + let resolve: undefined | ((value?: unknown) => void); const promise = new Promise((res, rej) => { - element.addEventListener('load', res, {once: true}); + if (!url) { + element.addEventListener('load', res, {once: true}); + } else { + resolve = res; + } element.addEventListener( 'error', event => { @@ -887,6 +892,9 @@ export class Frame { ); }); document.head.appendChild(element); + if (resolve) { + resolve(); + } await promise; return element; }, diff --git a/test/src/page.spec.ts b/test/src/page.spec.ts index c2708305d2822..68403bd49986f 100644 --- a/test/src/page.spec.ts +++ b/test/src/page.spec.ts @@ -1797,7 +1797,7 @@ describe('Page', function () { error = error_ as Error; } expect(error.message).toBe( - 'Provide an object with a `url`, `path` or `content` property' + 'Exactly one of `url`, `path`, or `content` may be specified.' ); });