From 65a5ce8464c56fcc55e5ac3ed490f31311bbe32a Mon Sep 17 00:00:00 2001 From: jrandolf <101637635+jrandolf@users.noreply.github.com> Date: Tue, 16 Aug 2022 10:09:07 +0200 Subject: [PATCH] fix: deprecate `root` in `WaitForSelectorOptions` (#8795) --- docs/api/puppeteer.waitforselectoroptions.root.md | 4 ++++ src/common/IsolatedWorld.ts | 3 +++ 2 files changed, 7 insertions(+) diff --git a/docs/api/puppeteer.waitforselectoroptions.root.md b/docs/api/puppeteer.waitforselectoroptions.root.md index 3b2aa5d7e15ad..d8a2b946f28e4 100644 --- a/docs/api/puppeteer.waitforselectoroptions.root.md +++ b/docs/api/puppeteer.waitforselectoroptions.root.md @@ -4,6 +4,10 @@ sidebar_label: WaitForSelectorOptions.root # WaitForSelectorOptions.root property +> Warning: This API is now obsolete. +> +> Do not use. Use the [ElementHandle.waitForSelector()](./puppeteer.elementhandle.waitforselector.md) + **Signature:** ```typescript diff --git a/src/common/IsolatedWorld.ts b/src/common/IsolatedWorld.ts index 0550bfd10aba1..6699091688fdf 100644 --- a/src/common/IsolatedWorld.ts +++ b/src/common/IsolatedWorld.ts @@ -77,6 +77,9 @@ export interface WaitForSelectorOptions { * @defaultValue `30000` (30 seconds) */ timeout?: number; + /** + * @deprecated Do not use. Use the {@link ElementHandle.waitForSelector} + */ root?: ElementHandle; }