New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ::Rack::Handler::Puma.run to work regardless of whether Rack/Rackup are loaded #3080
Conversation
Is it possible to get a |
turbo-rails is using Capybara & Puma 6.1.0 in their CI. See: https://github.com/hotwired/turbo-rails/actions/runs/4253429159/jobs/7398287552#step:3:131 Hence, is there more information you can give? EDIT: turbo-rails is using Rack 2, so never mind if you're using Rack 3. Not sure if that would work... |
It's from a private repo, but:
|
But to be clear, this PR fixes the issue. It just hasn't been released to rubygems yet. |
…ckup are loaded (#3080) * rack/handler/puma.rb - fix for use without Rack * test/test_rack_handler.rb - add test for rackup bin file * test_rack_server.rb - only load needed Rack files * test_rack_handler.rb - remove Windows skip for test_bin
Done 👍 |
<3 you @nateberkopec |
Description
PR #3061 fixed the use of the
rackup
bin file for use with either Rack 2 or Rack 3. It broke the use of::Rack::Handler::Puma.run
when used stand-alone, which is used to start Puma in some CI frameworks.Fix the above issues, add a test for running the
rackup
bin file usingIO.popen
, which isolates it (and what it requires) from the main test process. Note that the test only runs on MRI Ruby, as non-MRI Rubies take time when usingIO.popen
.The 'Tests' workflow uses the Rackup (includes the rackup bin) & Rack v3 gems, and the 'Rack_v2' workflow uses Rack v2 gem (includes the rackup bin).
See #2990 (comment)
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.