Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbo-rails.yml #3066

Merged
merged 2 commits into from Feb 2, 2023
Merged

Conversation

MSP-Greg
Copy link
Member

Description

When the turbo-rails workflow was added, it was rather 'hacky'. After trying a better way with the rack-conform workflow, returned to the turbo-rails file...

Modify Gemfile to use Puma from Repo & SHA generating workflow, misc changes.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

Is that a meaningful fail? I can't tell 🤔

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Jan 25, 2023

Is that a meaningful fail? I can't tell

Not sure myself. It seems like it's either a GitHub network issue or an edge case with Actions caching. The failure was with bundle install, or, it didn't even get to testing. The error shown:

  Revision 768c413f01dbcc2e7a7ca787eec07cf00b638b98 does not exist in the
  repository https://github.com/puma/puma.git. Maybe you misspelled it?
  If this error persists you could try removing the cache directory

But, 768c413 is valid...

Trying a rebase, CI will run both here and in my fork.

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Jan 25, 2023

My fork passed, by another failure here with Ruby 3.1. Going to force a bundler update in setup-ruby, and see if that fixes the issue.

EDIT: After adding the change to update bundler, passed both here and in my fork.

Modify Gemfile to use Puma from Repo & SHA generating workflow, misc changes
@MSP-Greg
Copy link
Member Author

MSP-Greg commented Feb 2, 2023

Just rebased...

All the turbo-rails jobs passed both here and in my fork.

All the test jobs passed except 'NON-MRI: macos-11 truffleruby' in my fork.

EDIT: Of course, when I merge, I suspect we won't be so lucky...

@MSP-Greg MSP-Greg merged commit 87c052f into puma:master Feb 2, 2023
@MSP-Greg MSP-Greg deleted the 00-turbo-rails-update branch February 2, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants