Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using rack 3. Receive deprecation warning. #3057

Closed
mmarvb8h opened this issue Jan 15, 2023 · 6 comments · Fixed by #3061
Closed

Using rack 3. Receive deprecation warning. #3057

mmarvb8h opened this issue Jan 15, 2023 · 6 comments · Fixed by #3061

Comments

@mmarvb8h
Copy link

Describe the bug
deprecation warning: "Rack::Handler is deprecated and replaced by Rackup::Handler"

Spent a little time to determine the issue. The issue seems to be when rackup.rb requires puma.rb. puma.rb does a require on rack/handler.rb on about line 3. rack/handler.rb throws deprecation warning.

Expected behavior
App should start without deprecation warning.

Desktop (please complete the following information):

  • OS: Mac M1 arm
  • Puma Version 6.0.2
  • rack version 3.0.3

~Marvin Foster
email: mmarvb7@gmail.com or marvinfoster@finsync.com

@dentarg
Copy link
Member

dentarg commented Jan 16, 2023

Can you post complete code and steps to reproduce?

@nateberkopec
Copy link
Member

I'm guessing you just need rack 3+ in the Gemfile or otherwise loaded for this to occur.

@MSP-Greg
Copy link
Member

MSP-Greg commented Jan 20, 2023

I think the issue is when using both rack 3 and rackup (rackup was included with rack 2)

See jeremyevans/roda#301 (comment)

When an app is started with the rackup bin file, we're using Rack::Handler, but with rack 3, the namespace is Rackup::Handler. I.think...

@MSP-Greg
Copy link
Member

I've got a patch which works when using the rackup bin, but I need to fix the tests...

@MSP-Greg
Copy link
Member

@mmarvb8h Don't know if you can easily test a PR, but I believe PR #3061 fixes this issue.

@mmarvb8h
Copy link
Author

mmarvb8h commented Feb 8, 2023

Sorry been focused on elsewhere. since all does seem to work. i'm comfortable with warning for now. since i generally use puma anyway i can start puma directly. in order for me to push to a "prod-like" state i needed to verify cause. when pushed fix is verified and released i'll just update puma. thx...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants