New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using rack 3. Receive deprecation warning. #3057
Comments
Can you post complete code and steps to reproduce? |
I'm guessing you just need rack 3+ in the Gemfile or otherwise loaded for this to occur. |
I think the issue is when using both rack 3 and rackup (rackup was included with rack 2) See jeremyevans/roda#301 (comment) When an app is started with the rackup bin file, we're using Rack::Handler, but with rack 3, the namespace is Rackup::Handler. I.think... |
I've got a patch which works when using the rackup bin, but I need to fix the tests... |
Sorry been focused on elsewhere. since all does seem to work. i'm comfortable with warning for now. since i generally use puma anyway i can start puma directly. in order for me to push to a "prod-like" state i needed to verify cause. when pushed fix is verified and released i'll just update puma. thx... |
Describe the bug
deprecation warning: "Rack::Handler is deprecated and replaced by Rackup::Handler"
Spent a little time to determine the issue. The issue seems to be when rackup.rb requires puma.rb. puma.rb does a require on rack/handler.rb on about line 3. rack/handler.rb throws deprecation warning.
Expected behavior
App should start without deprecation warning.
Desktop (please complete the following information):
~Marvin Foster
email: mmarvb7@gmail.com or marvinfoster@finsync.com
The text was updated successfully, but these errors were encountered: