Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Cleanup turbo_rails.yml #3051

Merged
merged 1 commit into from Jan 1, 2023
Merged

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Jan 1, 2023

Description

The turbo_rails workflow currently hardcodes the Ruby ABI version. Compute the value in the bash script. A fix for code I wrote...

Note that the tests will intermittently fail on the first test running a websocket connection. Haven't found a good fix, it seems to be caused by all the assets not being loaded by the client before the test code sends client websocket data.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec
Copy link
Member

Happy New Year @MSP-Greg ! I was going to do a 6.0.2 release so that #3035 could go live. Anything else you want to throw in quickly?

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Jan 1, 2023

@nateberkopec

And a Happy New Year to you also. Here, possibly 11" (28 cm) of snow...

Anything else you want to throw in quickly?

Just this. Almost done with CI.

@MSP-Greg MSP-Greg merged commit aed2f9a into puma:master Jan 1, 2023
@MSP-Greg MSP-Greg deleted the 00-fix-turbo-rails branch January 1, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants