New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preload_app
doesn't default to true
if more than 1 worker
#3044
Comments
Thanks for this great summary. I've actually come to the same conclusion before, at #2481 (comment) and in #2483. I think what was discussed in #2483 for Puma 6 must have been forgotten. Something for Puma 7? 😂 Maybe this issue can be the issue tracking it this time... |
So, Puma will preload your app if you start it using |
App preloading (in cluster mode) would solve the issue #2818 too as this would make the |
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
… parsed and config files are loaded
Describe the bug
The comment and the code suggest that if there are more than 1 worker,
preload_app
should betrue
, but it isn't.Puma config:
The command line option is
-w 2
.To Reproduce
a.sh
:This happens because at this point
@options[:workers]
is 0, since file options become available here, and user options here.Just in case, this has nothing to do with
docker
.Expected behavior
Either it should default to
true
, or that piece should be removed.Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: