Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of etc and time gems in Puma #3035

Merged
merged 3 commits into from Dec 24, 2022

Conversation

MSP-Greg
Copy link
Member

Description

Several years ago the etc and time gems were added to Puma's requirements. They are no longer needed, as a small code change replaces time, and I can't find any reference to etc.

Closes #3033.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

@nateberkopec bug, refactor, or feature ?

@johnnyshields
Copy link
Contributor

LGTM

@nateberkopec nateberkopec merged commit 97ec248 into puma:master Dec 24, 2022
@MSP-Greg MSP-Greg deleted the 00-remove-time branch December 24, 2022 15:37
@nateberkopec nateberkopec mentioned this pull request Jan 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phased restart issue with Ruby default Gem date
3 participants