Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Request normalize_env private for Puma 6 #2960

Merged

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Sep 15, 2022

Description

The code says make it private for Puma 6. Complete this todo.

Make Request normalize_env method private for Puma 6.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@JuanitoFatas JuanitoFatas changed the title Make Request normalize_env private Make Request normalize_env private for Puma 6 Sep 15, 2022
@JuanitoFatas JuanitoFatas marked this pull request as ready for review September 15, 2022 12:19
@nateberkopec nateberkopec merged commit 6e52e64 into puma:master Sep 16, 2022
@JuanitoFatas JuanitoFatas deleted the puma6/request-normalize_env-private branch September 16, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants