Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wait_for_less_busy_worker default #2940

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Make wait_for_less_busy_worker default #2940

merged 1 commit into from
Sep 10, 2022

Conversation

cafedomancer
Copy link
Contributor

@cafedomancer cafedomancer commented Sep 10, 2022 •
edited by nateberkopec

Description

Closes #2937.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@cafedomancer cafedomancer marked this pull request as ready for review September 10, 2022 04:06
@cafedomancer cafedomancer changed the base branch from master to move-config-constants September 10, 2022 04:07
@nateberkopec nateberkopec merged commit 19cc8cc into puma:move-config-constants Sep 10, 2022
@nateberkopec nateberkopec linked an issue Sep 10, 2022 that may be closed by this pull request
Make wait_for_less_busy_worker default #2937
Closed
nateberkopec added a commit that referenced this pull request Sep 10, 2022
@nateberkopec @cafedomancer
Refactor/move configuration defaults (#2928)
9a2c334 
* Refactor/move configuration defaults

* Make wait_for_less_busy_worker default (#2940)

Co-authored-by: Shohei Umemoto <cafedomancer@gmail.com>
@cafedomancer cafedomancer deleted the make-wait-default branch September 10, 2022 04:57
texpert added a commit to texpert/florsan that referenced this pull request Oct 19, 2022
@texpert
Remove Puma setting wait_for_less_busy_worker - it is now a default, …
7053792 
…see puma/puma#2940
texpert added a commit to texpert/rails_6_rss_reader that referenced this pull request Oct 19, 2022
@texpert
Remove Puma setting wait_for_less_busy_worker - it is now a default, …
3f915c0 
…see puma/puma#2940
@stringiest stringiest mentioned this pull request Oct 27, 2023
Merged
@joshuay03 joshuay03 mentioned this pull request Apr 16, 2024
Merged
7 tasks
@joshuay03 joshuay03 mentioned this pull request May 19, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change feature perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make wait_for_less_busy_worker default
2 participants
@cafedomancer @nateberkopec