Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nakayoshi GC #2933

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Remove nakayoshi GC #2933

merged 1 commit into from
Sep 9, 2022

Conversation

cafedomancer
Copy link
Contributor

@cafedomancer cafedomancer commented Sep 8, 2022 •
edited

Description

Because it's not performant as expected. Closes #2925.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@cafedomancer cafedomancer marked this pull request as ready for review September 9, 2022 00:04
@nateberkopec nateberkopec merged commit 57d7cf5 into puma:master Sep 9, 2022
@cafedomancer cafedomancer deleted the remove-nakayoshi-gc branch September 9, 2022 00:10
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
@cafedomancer @JuanitoFatas
Remove nakayoshi GC (puma#2933)
9acbf38
texpert added a commit to texpert/rails_6_rss_reader that referenced this pull request Oct 14, 2022
@texpert
Remove nakayoshi_fork, as it was removed from Puma - puma/puma#2933
7a5fa97
texpert added a commit to texpert/florsan that referenced this pull request Oct 14, 2022
@texpert
Remove nakayoshi_fork, as it was removed from Puma - puma/puma#2933
105972a
@stringiest stringiest mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nakayoshi GC
2 participants
@cafedomancer @nateberkopec