Refactor/move configuration defaults #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
force-pushed
the
move-config-constants
branch
7 times, most recently
from
9971459
to
f393365
Compare
nateberkopec
commented
Sep 8, 2022
nateberkopec
commented
Sep 8, 2022
| @@ -539,7 +539,6 @@ def test_config_loads_correct_min_threads | |||
|
|
|||
| def test_config_loads_correct_max_threads | |||
| conf = Puma::Configuration.new | |||
| assert_equal conf.default_max_threads, conf.options.default_options[:max_threads] | |||
There was a problem hiding this comment.
this is now covered by another test
nateberkopec
added
waiting-for-review
nateberkopec
force-pushed
the
move-config-constants
branch
from
f393365
to
057467f
Compare
|
I think this is good but would like a review |
7 tasks
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is not signed because I didn't have my key with me, will sign and force push later)Signed now
Closes #2922