Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all environment variables with PUMA_ #2924

Conversation

cafedomancer
Copy link
Contributor

@cafedomancer cafedomancer commented Sep 4, 2022

Description

Add PUMA_ fix to all the puma specific environment variables in preparation for Puma 6 release.

Close #2853.

List of all environment variables in Puma codebase
  • puma
    • PUMA_BUNDLER_PRUNED
    • PUMA_DEBUG
    • PUMA_LOG_CONFIG
    • PUMA_NO_RUBOCOP
    • PUMA_DISABLE_SSL (formerly DISABLE_SSL)
    • PUMA_MAKE_WARNINGS_INTO_ERRORS (formerly MAKE_WARNINGS_INTO_ERRORS)
    • PUMA_WAIT_FOR_LESS_BUSY_WORKERS (formerly WAIT_FOR_LESS_BUSY_WORKERS)
    • commit_info
  • systemd
    • LISTEN_FDS
    • LISTEN_PID
    • NOTIFY_SOCKET
    • WATCHDOG_USEC
  • rack, rails
    • APP_ENV
    • RACK_ENV
    • RAILS_ENV
  • ruby, rubygems, bundler
    • BUNDLE_APP_CONFIG
    • BUNDLE_GEMFILE
    • GEM_HOME
    • RUBYOPT
  • heroku
    • PUMA_MAX_THREADS, MAX_THREADS
    • PUMA_MIN_THREADS, MIN_THREADS
    • WEB_CONCURRENCY
  • others
    • CI
    • DYNO
    • GITHUB_ACTIONS
    • GITHUB_REPOSITORY
    • PORT
    • PWD
    • RAND
    • REDIS_URL
    • TEST_CASE_TIMEOUT

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@cafedomancer cafedomancer force-pushed the prefix-all-environment-variables-with-puma branch from d02a624 to dafe3f8 Compare September 6, 2022 04:54
@cafedomancer cafedomancer marked this pull request as ready for review September 6, 2022 05:17
@nateberkopec
Copy link
Member

@dentarg @MSP-Greg see note in the PR about all the variables we have, LMK if you think any others should be converted.

Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I'll note there's also LISTEN_PID for systemd (and these all seem to be standard names so they should not be prefixed)

@cafedomancer
Copy link
Contributor Author

cafedomancer commented Sep 6, 2022

I'll note there's also LISTEN_PID for systemd (and these all seem to be standard names so they should not be prefixed)

Thank you. Added LISTEN_PID to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix all environment variables with PUMA_
3 participants