Puma 6 gemspec - required_ruby_version to Ruby 2.4, RuboCop updates #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
2.4 works for me 👍 |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
…uma#2919) * Puma 6 - required_ruby_version to Ruby 2.4 * Actions - remove Ruby 2.2 & 2.3, add macOS 12 * Update Rubocop, disable Cops as needed to pass
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Puma 5 gemspec sets Ruby version compatibility to Ruby 2.2 and later. Update that to Ruby 2.4.
Remove Ruby 2.2 and 2.3 from CI testing.
This allows using a newer version of RuboCop. Updated the versions used, and disabled a few Cops to keep CI passing.
See Issue #1811 'Rev the minimum Ruby Version >= Ruby 2.5' from June 2018.
We could jump to 2.5...
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.