Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix all environment variables with PUMA_ #2853

Closed
nateberkopec opened this issue Apr 2, 2022 · 3 comments · Fixed by #2924
Closed

Prefix all environment variables with PUMA_ #2853

nateberkopec opened this issue Apr 2, 2022 · 3 comments · Fixed by #2924
Assignees
@timrogers
Labels
breaking change contrib-wanted feature
Milestone
6.0.0

Comments

@nateberkopec
Copy link
Member

Currently we're reading DISABLE_SSL. We should rename all env variables to read PUMA_ (except the env variables that are defined by the community: RAILS_MAX_THREADS, probably others I can't think of right now).
@nateberkopec nateberkopec added this to the 6.0.0 milestone Apr 2, 2022
@timrogers
Copy link

👋 I'm up for picking this up, if that's okay? ❤️

@nateberkopec
Copy link
Member Author

@timrogers Just checking in, are you still working on this? Do you need assistance?

@timrogers
Copy link

👋🏻 Yep! I think this issue is mostly discussion and decision rather than actually implementation, so I'll share some thoughts here soon.

@cafedomancer cafedomancer mentioned this issue Sep 4, 2022
Merged
7 tasks
@stringiest stringiest mentioned this issue Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timrogers timrogers

Labels
breaking change contrib-wanted feature
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Prefix all environment variables with PUMA_ cafedomancer/puma
2 participants
@timrogers @nateberkopec