New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Always send lowlevel_error response to client (#2731)" #2809
Conversation
I think the TruffleRuby issues are unrelated (fails on compile step): https://github.com/puma/puma/runs/4953876626?check_suite_focus=true#step:7:12 |
@dentarg The issue with truffleruby there, could that be sidestepped by a |
@olleolleolle Maybe, but I don't think we should need to do that? On the other hand, all MRI jobs have the argument Ping @MSP-Greg |
Hmm, it failed with plain ruby/setup-ruby too: https://github.com/dentarg/puma/runs/4971018457?check_suite_focus=true
@eregon Is this an issue in ruby/setup-ruby or with TruffleRuby? |
Already reported as oracle/truffleruby#2586. |
Another fallout from puma#2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well.
Another fallout from #2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well.
Another fallout from #2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well.
* Ensure `close` is called on the response body no matter what Another fallout from #2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well. * 5.6.2 Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
Another fallout from puma#2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well.
Another fallout from puma#2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well.
Another fallout from puma#2809 is that in some cases the `res_body.close` wasn't called because some previous code raised. For Rails apps it means CurrentAttributes and a few other important states aren't reset properly. This is being improved on the Rails side too, but I believe it would be good to harden this on the puma side as well.
This reverts commit f8acac1.
In response to #2808