Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update actions, fix intermittent test error #2801

Merged
merged 2 commits into from Jan 17, 2022

Conversation

MSP-Greg
Copy link
Member

Description

Currently CI is running on a 'special' branch of MSP-Greg/setup-ruby-pkgs. It and ruby/setup-ruby have been updated to work with Ruby 3.1 and the new windows-2022 image. Revert to the normal branches.

Fixes an intermittent error in test/test_integration_pumactl.rb

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg
Copy link
Member

dentarg commented Jan 16, 2022

What's up with Ruby 2.5 and your repos/branches (MSP-Greg/setup-ruby-pkgs@win-ucrt-2, MSP-Greg/ruby-setup-ruby/win-ucrt-1)?

I can't make sense of the error but it looks like it happens consistently in that setup.

It doesn't happen with plain ruby/setup-ruby: https://github.com/dentarg/puma/runs/4834198864?check_suite_focus=true#step:9:71 (tested only with Ubuntu)

@dentarg
Copy link
Member

dentarg commented Jan 16, 2022

Would it be possible to only use ruby/setup-ruby in Puma? To make it more clear what is needed to run/test Puma on different platforms. We could make use of reusable workflows to re-use things.

@MSP-Greg
Copy link
Member Author

What's up with Ruby 2.5

It appears to be a weird (and intermittent) error due to old RubyGems being incompatible with new Psych. The reason it wasn't failing for a while was that the original code I had was doing gem update --system for Rubies 2.3 thru 2.5 instead of just installing Bundler, as is now done with code in ruby/setup-ruby. The branch I used here was changed since it was also the branch used for the PR in setup-ruby. I'm trying to get a repo case...

Would it be possible to only use ruby/setup-ruby in Puma?

Depends. To test Windows Rubies 2.2 thru 3.1 (or master) requires three OpenSSL versions and two ragel versions. The other OS's are simpler. The readme could state that ragel and openssl are needed.

@dentarg
Copy link
Member

dentarg commented Jan 16, 2022

It appears to be a weird (and intermittent) error due to old RubyGems being incompatible with new Psych.

Yeah, but not intermittent? Looks it like fails every time now

@MSP-Greg
Copy link
Member Author

I really don't know. Kind of dealing with some normal things.

Take a look at my fork of setup-ruby:
https://github.com/MSP-Greg/ruby-setup-ruby/actions/runs/1705378024

So I pushed it as a PR to setup-ruby, see:
https://github.com/ruby/setup-ruby/actions/runs/1705416015

My fork had the same failure as here, but the PR passed. I think it's affected by Actions caching. Not.Sure.

That wasn't using either of my repos (the fork or MSP-Greg/setup-ruby-pkgs).

@MSP-Greg
Copy link
Member Author

Screw it, I just added the code to run gem update --system for Rubies 2.3 thru 2.5, as I had in the CI that was running before that worked...

@dentarg
Copy link
Member

dentarg commented Jan 17, 2022

I think it's affected by Actions caching

You are on to something. See dentarg@4ceaec5 where I switched off cache for the MSP-Greg/setup-ruby-pkgs jobs (Ruby 2.5 passed) and switched it on for ruby/setup-ruby and Ruby 2.5 failed!

I guess we continue to discuss this in ruby/setup-ruby#264

@MSP-Greg MSP-Greg merged commit aec9fb3 into puma:master Jan 17, 2022
@MSP-Greg MSP-Greg mentioned this pull request Jan 17, 2022
7 tasks
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
* Update Actions

* TestIntegrationPumactl#test_phased_restart_cluster - time to 6

Fixes rare failures on Ubuntu 18.04
@MSP-Greg MSP-Greg deleted the update-actions branch October 23, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants