Log environment using option value #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for the configured environment to be something other than `RACK_ENV`, e.g. `APP_ENV` or `RAILS_ENV`, but the runner will always log the value of `RACK_ENV`. This changes the log output to show the configured environment value. See https://github.com/puma/puma/blob/v5.5.2/lib/puma/configuration.rb#L203
ags
force-pushed
the
log-environment-option
branch
from
2e8c0c0
to
93d3e63
Compare
|
Makes sense. That's a bug. |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
It's possible for the configured environment to be something other than `RACK_ENV`, e.g. `APP_ENV` or `RAILS_ENV`, but the runner will always log the value of `RACK_ENV`. This changes the log output to show the configured environment value. See https://github.com/puma/puma/blob/v5.5.2/lib/puma/configuration.rb#L203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's possible for the configured environment to be something other than
RACK_ENV, e.g.APP_ENVorRAILS_ENV, but the runner will always log the value ofRACK_ENV.This changes the log output to show the configured environment value.
See https://github.com/puma/puma/blob/v5.5.2/lib/puma/configuration.rb#L203