Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning from Ruby master (will be 3.2.0) #2785

Merged
merged 2 commits into from Jan 2, 2022

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Jan 1, 2022

Description

Fixes warning: undefining the allocator of T_DATA class Puma::MiniSSL::Engine which is the result of a (good) change to Ruby master (v3.2.0).

Removes unused variable in test_puma_server_ssl.rb - Fix warning: assigned but unused variable

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit cec07ac into puma:master Jan 2, 2022
@MSP-Greg MSP-Greg deleted the undef-allocator branch January 2, 2022 14:52
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Fix: warning: undefining the allocator of T_DATA class Puma::MiniSSL::Engine
test_puma_server_ssl.rb - Fix warning: assigned but unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants