Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yaml (psych) requirement in StateFile #2784

Merged
merged 2 commits into from Jan 1, 2022
Merged

Remove yaml (psych) requirement in StateFile #2784

merged 2 commits into from Jan 1, 2022

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Jan 1, 2022

Description

Update code and tests for StateFile:

  1. remove yaml requirement for lib code
  2. improve tests
  3. deprecate lib constants only used for testing

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg changed the title Remove yaml requirement in StateFile Remove yaml (psych) requirement in StateFile Jan 1, 2022
@MSP-Greg MSP-Greg merged commit 2b6968f into puma:master Jan 1, 2022
@MSP-Greg MSP-Greg deleted the state-file branch January 1, 2022 21:53
MSP-Greg pushed a commit that referenced this pull request Jan 27, 2022
@kzkn
Fix Puma::StateFile#load returns empty string instead of nil (#2810)
93815b2 
Bug introduced in 2b6968f #2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
MSP-Greg pushed a commit to MSP-Greg/puma that referenced this pull request Apr 2, 2022
@kzkn @MSP-Greg
Fix Puma::StateFile#load returns empty string instead of nil (puma#…
68fc1ba 
…2810)

Bug introduced in 2b6968f puma#2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
MSP-Greg pushed a commit to MSP-Greg/puma that referenced this pull request Apr 3, 2022
@kzkn @MSP-Greg
Fix Puma::StateFile#load returns empty string instead of nil (puma#…
adc94f4 
…2810)

Bug introduced in 2b6968f puma#2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
nateberkopec pushed a commit that referenced this pull request Aug 22, 2022
@kzkn @nateberkopec
Fix Puma::StateFile#load returns empty string instead of nil (#2810)
c36d644 
Bug introduced in 2b6968f #2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
@MSP-Greg @JuanitoFatas
Remove yaml (psych) requirement in StateFile (puma#2784)
2505955 
Don't require yaml in state_file.rb
cli.rb & launcher.rb - deprecate state file constants
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
@kzkn @JuanitoFatas
Fix Puma::StateFile#load returns empty string instead of nil (puma#…
95874f7 
…2810)

Bug introduced in 2b6968f puma#2784

Until 5.5.2, empty values were read as `nil`.
Since 5.6.0, empty values are read as `""`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateberkopec nateberkopec nateberkopec approved these changes

Assignees
No one assigned
Labels
feature refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MSP-Greg @nateberkopec