Alternate worker culling strategy #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Dec 17, 2021
Comment on lines
-125
to
+135
| all_positions = 0...@options[:workers] | ||
| occupied_positions = @workers.map { |w| w.index } | ||
| available_positions = all_positions.to_a - occupied_positions | ||
| available_positions.first | ||
| occupied_positions = @workers.map(&:index) | ||
| idx = 0 | ||
| idx += 1 until !occupied_positions.include?(idx) | ||
| idx |
There was a problem hiding this comment.
The reason I changed this method's implementation is because I ran into an edge case while writing tests for this PR: if @options[:workers] is decreased (e.g. because the process received a TTOU signal), the previous implementation could potentially return nil.
MSP-Greg
approved these changes
Dec 18, 2021
|
Renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for an alternate worker culling strategy: instead of culling the workers at the end of the internal worker list (which in all likelihood are the most recently started workers), setting the new
worker_culling_strategyconfiguration option tooldestwill cull the workers which were started the longest time ago.This strategy makes it easier to implement a rolling restart of workers. This would be useful for us because our workers tend to leak memory over time. While of course the right thing to do would be write good code that does not leak memory :D in practice it's very hard and replacing workers every so often is a cheap and easy strategy.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.