Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for GitHub actions [ci skip] #2717

Merged
merged 1 commit into from Sep 29, 2021

Conversation

jacobherrington
Copy link
Contributor

Description

I think the location of this setting moved!

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg dentarg merged commit cf991f6 into puma:master Sep 29, 2021
@MSP-Greg
Copy link
Member

In my fork, I have to go to the 'Settings' tab (uri is the repo uri with /settings added), then click the 'Actions' tab on the left.

Do you have it in a different place?

@jacobherrington
Copy link
Contributor Author

By default, my fork had all of those options "enabled," but I had to navigate to https://github.com/jacobherrington/puma/actions and affirm a prompt to actually enable.

It is possible that this is only true for newer forks?

@dentarg
Copy link
Member

dentarg commented Sep 29, 2021

It is true for the first time after forking, just tried it with another GitHub account.

If you disable actions (via Settings) you need to enable it via Settings, but then you know how to find it because you managed to disable, so I don't think we need any guidance about that. :)

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants