Extract calls to purge_interrupt_queue #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move calls to Thread#purge_interrupt_queue to a module function. This means if/when this pattern needs to change it can change in one place instead of a dozen or more places.
|
Let's be specific in the comment about which older versions of ruby. When you deprecate/remove things, it's usually a workflow of "search all files for <RUBY VERSION STRING">. |
|
@nateberkopec I updated the comment, do we need to run CI again on this PR? |
jacobherrington
deleted the
jacobherrington/extract-purge-interrupt-queue-to-util
branch
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Extract calls to purge_interrupt_queue Move calls to Thread#purge_interrupt_queue to a module function. This means if/when this pattern needs to change it can change in one place instead of a dozen or more places. * Update comment on purge_interrupt_queue [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move calls to Thread#purge_interrupt_queue to a module function. This
means if/when this pattern needs to change it can change in one place
instead of a dozen or more places.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.