Clean up some duplicated code #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSP-Greg
reviewed
Sep 25, 2021
lib/puma/runner.rb
Outdated
| def wakeup! | ||
| return unless @wakeup | ||
|
|
||
| begin |
There was a problem hiding this comment.
Maybe remove begin and move the rescue to 'method level'?
lib/puma/runner.rb
Outdated
|
|
||
| private | ||
|
|
||
| def ensure_output_directory_exists(path) |
There was a problem hiding this comment.
Maybe something like:
def ensure_output_directory_exists(path, io_name)and pass 'STDOUT' or 'STDERR' to it, along with changing:
raise "Cannot redirect #{io_name} to #{path}"
Fine by me, not sure about others. Most older repos always have code that can be refactored. And, ruby/ruby is always refactoring... |
jacobherrington
force-pushed
the
jacobherrington/remove-code-duplication
branch
from
c47a836
to
25e210b
Compare
|
@MSP-Greg Thanks for the review, I pushed a new commit including your suggestions! |
|
We're 100% ok with refactors here. I wouldn't even call this style-oriented, you're removing code, not just changing quotation marks and whitespace. |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking through this file, I noticed some identical code that could be cleaned up.
This is only better subjectively, but I didn't see anything re: refactors in the contributing doc. If Puma tends to avoid style-oriented refactors like this one without a strong rationale, feel free to close this PR.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.