Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Fixes #2693

Merged
merged 1 commit into from Sep 7, 2021
Merged

Test Fixes #2693

merged 1 commit into from Sep 7, 2021

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Sep 7, 2021

Description

  1. Move SSLEventsHelper to test/helper.rb, fixes warning: method redefined
  2. Collapse 'Debugging Info' in Actions log
  3. Fix 'shadowed variable' warning

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

1. Move SSLEventsHelper to test/helper.rb, fixes `warning: method redefined`
2. Collapse 'Debugging Info' in Actions log
3. Fix 'shadowed cariable' warning
@nateberkopec nateberkopec merged commit a0cab5d into puma:master Sep 7, 2021
@MSP-Greg MSP-Greg deleted the move-SSLEventsHelper branch October 31, 2021 15:22
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
1. Move SSLEventsHelper to test/helper.rb, fixes `warning: method redefined`
2. Collapse 'Debugging Info' in Actions log
3. Fix 'shadowed cariable' warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants