Preserve BUNDLE_APP_CONFIG on worker fork #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlarose
requested changes
Sep 3, 2021
| @@ -39,6 +39,25 @@ def test_usr2_restart_preserves_bundler_environment | |||
| assert_match("Gemfile.bundle_env_preservation_test", new_reply) | |||
| end | |||
|
|
|||
| def test_worker_forking_preserves_bundler_config_path | |||
There was a problem hiding this comment.
Locally, if I undo the change introduced to prune_bundler,
git restore --source HEAD^ -- libThis test is still green. In other words, the test does not appear to guard against a regression for the new functionality.
Do you think it is possible to write this test in a way that it fails on master in the way you observed?
There was a problem hiding this comment.
Bah, I was testing with ruby -Ilib:test test/test_preserve_bundler_env.rb which does fail on master, but looks like the same thing inside of bundle exec doesn't.
I've force-pushed an update that sets BUNDLE_GEMFILE in the test, which should persuade it to fail in either scenario (and then subsequently be fixed by the BUNDLE_APP_CONFIG change).
Without this, if puma is launched with BUNDLE_APP_CONFIG set, that will be lost inside of unbundled_env, which causes the worker processes to use a potentially different bundler configuration.
jdelStrother
force-pushed
the
bundle-app-config
branch
from
c557efd
to
a8ea7e3
Compare
cjlarose
approved these changes
Sep 3, 2021
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Without this, if puma is launched with BUNDLE_APP_CONFIG set, that will be lost inside of unbundled_env, which causes the worker processes to use a potentially different bundler configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, if puma is launched with BUNDLE_APP_CONFIG set, that will
be lost inside of unbundled_env, which causes the worker processes to use a
potentially different bundler configuration.
Closes #2687
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.