Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg_config for OpenSSL if available #2648

Merged
merged 1 commit into from Jun 27, 2021

Conversation

MSP-Greg
Copy link
Member

Description

Check for 'pkg_config' when compiling with OpenSSL support.

Closes #1412

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Jun 22, 2021

Off-topic - CI issues

Recently there are problems with retrieving GPG keys, and this only affects installing OpenSSL 1.0.2 on Windows Ruby 2.4.

The package is stored on GitHub, so I disabled GPG validation only for the package in setup-ruby-pkgs. I restarted the CI MRI run here and also the CI MRI for #2610...

Hence, I re-started a few GitHub Actions jobs that failed...

@nateberkopec nateberkopec added the waiting-for-review Waiting on review from anyone label Jun 24, 2021
@nateberkopec
Copy link
Member

We can do this separately, but docs for how to use it wouldd be good.

@nateberkopec nateberkopec merged commit 4ff7d75 into puma:master Jun 27, 2021
@MSP-Greg MSP-Greg deleted the ssl-pkg-config branch October 31, 2021 15:22
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to override OpenSSL version w/pkg_config
2 participants