Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder#parse - allow for symlinked unix path, add create_activated_fds debug ENV #2643

Merged
merged 1 commit into from Jun 27, 2021

Conversation

MSP-Greg
Copy link
Member

Description

When systemd creates a UNIXSocket with a path that is contained in a symlinked directory, Ruby may read the path as the real path.

Closes #2638

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

…s debug ENV

When systemd creates a UNIXSocket with a path that is contained in a symlinked
directory, Ruby may read the path as the real path.
@nateberkopec nateberkopec merged commit 8264d20 into puma:master Jun 27, 2021
@MSP-Greg MSP-Greg deleted the 2638-systemd branch October 31, 2021 15:23
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
…s debug ENV (puma#2643)

When systemd creates a UNIXSocket with a path that is contained in a symlinked
directory, Ruby may read the path as the real path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is already a server bound to: /var/run/puma/puma.sock (after OS + ruby upgrade)
2 participants