Update docs for low_latency option and fix parsing issue #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the binder.parse code was just checking that the low_latency key existed, but the docs (and other options) support passing options in the format `option=false`. This commit now treats `low_latency=false` as false, while still treating `low_latency` with no `=` as true
JRuby (at least this version) doesn't support basic Socket constants or methods Ref: jruby/jruby#3438
|
Cheers and thanks for your contributions 🎉 |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Treat low_latency=false as false instead of true Previously the binder.parse code was just checking that the low_latency key existed, but the docs (and other options) support passing options in the format `option=false`. This commit now treats `low_latency=false` as false, while still treating `low_latency` with no `=` as true * Update docs to reflect code behaviour * Skip getsockopt tests in JRuby JRuby (at least this version) doesn't support basic Socket constants or methods Ref: jruby/jruby#3438
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2623
As well as updating the docs to reflect that TCP_NODELAY is off by default, I've tweaked the code so that
low_latency=falsedoesn't set TCP_NODELAY, which is consistent with how other options are parsed. Let me know if the tests are a bit overkill.I'm not sure how best to test that the created socket has or lacks TCP_NODELAY in JRuby, since this version of JRuby has a very minimal Socket implementation (no constants, no bool method). For now I've skipped my new tests if we're running them in JRuby, but any guidance would be appreciated.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.