Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle Rack not accepting CLI options #2630

Conversation

seangoedecke
Copy link
Contributor

Description

Closes #2626

In rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55R96, Rack removed the ability to pass options from the command line. It now fails when you try to do that, and no longer exposes them fromBuilder.load_file. Puma shouldn't fail when this happens.

This commit falls back to an empty object when Rack does not pass options back from Builder.load_file.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

In
rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55R96,
Rack removed the ability to pass options from the command line. It now
fails when you try to do that, and no longer exposes them from
`Builder.load_file`. Puma shouldn't fail when this happens.

This commit falls back to an empty object when Rack does not pass
options back from `Builder.load_file`.
@nateberkopec nateberkopec added bug waiting-for-review Waiting on review from anyone labels May 14, 2021
@nateberkopec nateberkopec merged commit f9e9102 into puma:master May 20, 2021
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
In
rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55R96,
Rack removed the ability to pass options from the command line. It now
fails when you try to do that, and no longer exposes them from
`Builder.load_file`. Puma shouldn't fail when this happens.

This commit falls back to an empty object when Rack does not pass
options back from `Builder.load_file`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puma will not start up when running against an (as yet) unreleased version of rack
2 participants