Fix sigterm misbehavior #2629
Merged
Fix sigterm misbehavior #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting from puma 5.x if worker crashes and exited, the cluster will try to restart the workers immediately without exponential time delay. I noticed puma will wait 1 sec in 4.x. Is it bug or expected behavior for 5.x? |
|
No idea on the exponential time delay backoff... want to open a separate issue? |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Log error if worker can not be started * Removed sleeping of worker * Runned rubocop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes 2222.
The current issue occurs if the server can't be started and raised exceptions before signal re-registration is done.I put the code to log the first line of back trace to gives consistent error log if there is some error in worker starts.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.