Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keepalive connections which exceed request limit closed in a less-than-clean manner with 5.3.1 #2627

Closed
nateberkopec opened this issue May 11, 2021 · 2 comments · Fixed by #2628
Closed

Keepalive connections which exceed request limit closed in a less-than-clean manner with 5.3.1 #2627

nateberkopec opened this issue May 11, 2021 · 2 comments · Fixed by #2628
Labels
bug

Comments

@nateberkopec
Copy link
Member

Observable with wrk/your favorite benchmarking tool.
@nateberkopec nateberkopec changed the title Connections closed in a less-than-clean manner with 5.3.1 Keepalive connections which exceed request limit closed in a less-than-clean manner with 5.3.1 May 11, 2021
@nateberkopec nateberkopec mentioned this issue May 11, 2021
Closed
@nateberkopec nateberkopec linked a pull request May 12, 2021 that will close this issue
Improvements to keepalive-connection shedding #2628
Merged
7 tasks
@justin808
Copy link

@nateberkopec any risk of this affecting normal production deployments? Or just benchmarking. We've been load-testing popmenu.com's infrastructure and we noticed a big reduction in the max load before we hit many errors.

@nateberkopec
Copy link
Member Author

I don't think there's much risk. It only affects connections which send more than 10 keepalive requests. We're gonna release a patch fixing this in a day or two.

@ndbroadbent ndbroadbent mentioned this issue May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to keepalive-connection shedding wjordan/puma
2 participants
@nateberkopec @justin808