Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define UNPACK_TCP_STATE_FROM_TCP_INFO in the right place #2588

Merged
merged 1 commit into from Apr 2, 2021

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Apr 1, 2021

Description

This fixes the issue for me when I run Puma in FreeBSD using Vagrant. Instructions for that over at https://github.com/dentarg/puma-vagrant/tree/0c858e572fff48b3148b3bec81518471393f94df#freebsd

Close #2556

This change is included in #2554, but that PR has a lot of other changes too, hopefully this will be easier to review, merge and release.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

This fixes the issue for me when I run Puma in FreeBSD using Vagrant.

Close puma#2556
@dentarg dentarg mentioned this pull request Apr 1, 2021
@nateberkopec nateberkopec merged commit 15b0794 into puma:master Apr 2, 2021
@dentarg dentarg deleted the freebsd-fix branch April 2, 2021 14:10
@dentarg dentarg added the bug label Apr 19, 2021
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
This fixes the issue for me when I run Puma in FreeBSD using Vagrant.

Close puma#2556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined constant on platforms without tcp_cork support and with closed_socket support
2 participants