Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.rb - fix chunked body assembly for ascii incompatible encodings #2585

Merged
merged 1 commit into from Mar 26, 2021

Conversation

MSP-Greg
Copy link
Member

Description

Went through several versions, benched all of them, and this seemed the best compromise for small and large (100kb) chunked bodies, both ascii compatible and not.

Closes #2583

Also, Fix TestPumaServer#test_custom_io_selector. On fast systems, stopping the server happened fast enough so that IOError: selector is closed was raised.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

…dd test

Fix TestPumaServer#test_custom_io_selector
Copy link
Member

@cjlarose cjlarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I verified that this change fixes the problem demonstrated by the example repo provided in #2583

@cjlarose cjlarose merged commit 403975b into puma:master Mar 26, 2021
@MSP-Greg MSP-Greg added the bug label Mar 26, 2021
@jboler
Copy link

jboler commented Mar 26, 2021

Amazing - thank you!

@MSP-Greg MSP-Greg deleted the 00-byte branch March 26, 2021 16:54
@nateberkopec
Copy link
Member

In retrospect, should have had a Changelog entry here.

Copy link

@Ayalewh Ayalewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passport number

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
…dd test (puma#2585)

Fix TestPumaServer#test_custom_io_selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants