Add support for Linux's abstract sockets #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSP-Greg
force-pushed
the
00-issue-2526-abstract
branch
from
acd9604
to
8abbee1
Compare
MSP-Greg
changed the title
|
Rebased and added two simple tests. The new test framework has a test or two creating hundreds of abstract unix clients... |
MSP-Greg
force-pushed
the
00-issue-2526-abstract
branch
from
8abbee1
to
23173a1
Compare
|
Thought I'd rebase this. Also, curl can be used to verify the PR. Compile the Puma repo, then # assumes tcp 127.0.0.1:40000 is available, change as needed
bundle exec ruby -Ilib bin/puma -q -w2 -t5:5 -b tcp://127.0.0.1:40000 test/rackup/realistic_response.ru
curl -kso /dev/null -w '%{size_download}' http://127.0.0.1:40000
bundle exec ruby -Ilib bin/puma -q -w2 -t5:5 -b unix://@puma.unix test/rackup/realistic_response.ru
curl -kso /dev/null -w '%{size_download}' --abstract-unix-socket puma.unix http:
The file realistic_response.ru actually returns a 200,000 byte body. Both curl commands should output 200000, which is the body byte size... |
lib/puma/binder.rb
Outdated
| @@ -374,7 +381,7 @@ def add_unix_listener(path, umask=nil, mode=nil, backlog=1024) | |||
| end | |||
| end | |||
|
|
|||
| s = UNIXServer.new(path) | |||
| s = UNIXServer.new path.sub(/\A@/, "\0") | |||
There was a problem hiding this comment.
Everywhere that we check for a socket starting with @, I think we should have a comment explaining this a check for an abstract socket.
nateberkopec
added
waiting-for-changes
|
Minor style concerns, otherwise LGTM |
MSP-Greg
force-pushed
the
00-issue-2526-abstract
branch
from
23173a1
to
8d51591
Compare
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Support Linux's abstract sockets Closes puma#2526 * Add two simple UNIXSocket tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2526
Tests for abstract UNIXSockets exist in the updated test framework. Will open a PR for it after all the library file changes have been accepted. Tested both server & control binding...
Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.