New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug to worker timeout and startup. Closes #2528 #2559
Add debug to worker timeout and startup. Closes #2528 #2559
Conversation
@@ -46,6 +46,10 @@ def teardown | |||
|
|||
private | |||
|
|||
def silent_and_checked_system_command(*args) | |||
assert(system(*args, out: File::NULL, err: File::NULL)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed err as bundler keeps on complaining my version is not the same as the one in the Gemfile.lock
I also added an assert to make sure the command exited with success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like failing tests needs to be addressed
I have fixed the ruby < 2.4 versions. Sadly I can't test locally as I don't have the right openssl version to compile the old rubies. Let's see if the CI is happy this time ;) |
CI is fine, current CI has intermittent failures/errors for all platforms/versions. See: https://github.com/MSP-Greg/puma/actions/runs/626438062, failures here passed, ubuntu-18.04 2.6 failed. |
If you can use Docker, it is as simple as |
Co-authored-by: Patrik Ragnarsson <patrik@starkast.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the CI failures are not related
(18.04 2.7 flaky test_hot_restart_does_not_drop_connections
and Win 2019 2.3 SignalException: SIGSEGV
, flake too?)
Logs reason for worker timeout and the startup time when worker boots
Description
Fixes #2528 adding the reason for worker timeout and the startup time when worker boots
Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.