Set @env[CONTENT_LENGTH] value as string. #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2021 22:40
Update tests to reflect that CONTENT_LENGTH is now a string. Add change to History.md.
dentarg
reviewed
Feb 3, 2021
Co-authored-by: Patrik Ragnarsson <patrik@starkast.net>
|
Thanks @nmb! |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Set @env[CONTENT_LENGTH] value as string. * Update tests. Update tests to reflect that CONTENT_LENGTH is now a string. Add change to History.md. * Update History.md Co-authored-by: Patrik Ragnarsson <patrik@starkast.net> Co-authored-by: Patrik Ragnarsson <patrik@starkast.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rack expects CGI keys as strings (see lint.rb).
Your checklist for this pull request
[changelog skip]or[ci skip]to the pull request title.If this PR doesn't need tests (docs change), I added[ci skip]to the title of the PR.If this closes any issues, I have added "Closes#issue" to the PR description or my commit messages.I have updated the documentation accordingly.