Remove Server#read_body #2531
Merged
Remove Server#read_body #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused method leftover from previous refactoring.
wjordan
force-pushed
the
remove_server_read_body
branch
from
b13c021
to
8893c2c
Compare
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Unused method leftover from previous refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server#read_bodyseems to have been left behind as part of a refactoring done in 6777c77, where the contents of this method were copied into the newly-createdClientclass but never removed fromServer, even though it's no longer called anywhere. This PR removes the unused method.