Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make illegal header matching more stringent #2510

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

micke
Copy link
Contributor

@micke micke commented Dec 10, 2020

Description

This PR fixes some false positive matches that was introduced in #2439

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@micke
Copy link
Contributor Author

micke commented Dec 10, 2020

Special thanks to @loveapoex and @stefanahman for the great detective work! 🕵🏽

@nateberkopec
Copy link
Member

Good catch! I think this is worth a new patch release.

@nateberkopec nateberkopec merged commit 95b5175 into puma:master Dec 10, 2020
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants